Alon Bar-Lev has posted comments on this change. Change subject: 9. [WIP] core: Introducing AuthenticationProfileRepository ......................................................................
Patch Set 26: (1 comment) http://gerrit.ovirt.org/#/c/24366/26/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java: Line 82: authenticator.init(); Line 83: Line 84: AuthenticationProfile profile = new AuthenticationProfile(authenticator, directory); Line 85: Line 86: AuthenticationProfileRepository.getInstance().registerProfile(profile); > Please read the comment - not until I move this to its own module. This is ok, no problem... just strange :))) BTW: usually I do not read the comments... so I won't be confused when reading the code :) Line 87: } Line 88: Line 89: ExtensionManager.getInstance().load(EngineLocalConfig.getInstance()); Line 90: AuthenticationProfileRepository.getInstance(); -- To view, visit http://gerrit.ovirt.org/24366 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If375fccea98544c64d9ec41cc9dbcb855bf02fb7 Gerrit-PatchSet: 26 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
