Roy Golan has posted comments on this change.

Change subject: packaging: setup: database: support get vdc option's versions
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.ovirt.org/#/c/24844/1/packaging/setup/ovirt_engine_setup/database.py
File packaging/setup/ovirt_engine_setup/database.py:

Line 213: )
raise an error as getVdcOption does so the behaviour is same


Line 214: version
return the whole thing why return only the version?

I expect to iterate over each value per each version


-- 
To view, visit http://gerrit.ovirt.org/24844
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4c36d59afbc502f0bb28b0bbad1315f4e9c65702
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to