Yair Zaslavsky has posted comments on this change. Change subject: aaa: Introducing Extension manager ......................................................................
Patch Set 24: (1 comment) http://gerrit.ovirt.org/#/c/24365/24/backend/manager/modules/extension-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionManager.java File backend/manager/modules/extension-manager/src/main/java/org/ovirt/engine/core/extensions/mgr/ExtensionManager.java: Line 210: for (ExtensionEntry entry : loadedEntries.values()) { Line 211: if (entry.enabled) { Line 212: try { Line 213: Extension extension = Line 214: lookupExtension(entry, loadModule(entry.getConfig().getProperty(MODULE))).newInstance(); > if you go down a line, please do this like: done Line 215: extension.setContext(entry.context); Line 216: extension.init(); Line 217: entry.setExtension(extension); Line 218: activatedEntries.put(entry.getName(), entry); -- To view, visit http://gerrit.ovirt.org/24365 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I182904177ec088e62b35bde870ec79725fabc4e4 Gerrit-PatchSet: 24 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
