Omer Frenkel has posted comments on this change. Change subject: core: block migration for paused vm only in case of an error ......................................................................
Patch Set 4: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/24640/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MigrateVmCommand.java: Line 310: case NotResponding: Line 311: return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_VM_STATUS_ILLEGAL, LocalizedVmStatus.from(VMStatus.NotResponding)); Line 312: Line 313: case Paused: Line 314: if (vm.getVmPauseStatus() != VmPauseStatus.NOERR) { i might be confused, but just to be sure, what about VmPauseStatus.NONE ? Line 315: return failCanDoAction(VdcBllMessages.MIGRATE_PAUSED_ERR_VM_IS_UNSUPPORTED); Line 316: } Line 317: break; Line 318: -- To view, visit http://gerrit.ovirt.org/24640 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic6e7a7d41fcf66e2d3c13b93de7dd68b42aeaecb Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
