Liron Ar has posted comments on this change. Change subject: core: Introducing OvfOnAnyDomain feature ......................................................................
Patch Set 9: (3 comments) http://gerrit.ovirt.org/#/c/23467/9//COMMIT_MSG Commit Message: Line 19: the ovf store disk on the domain. Line 20: Line 21: Currently most of the operation are blocked for ovf disks, they will be Line 22: enabled in further patches. Line 23: > Add link to bugzilla RFE. Done Line 24: Change-Id: I78803db10947a6ee477a493b530319654b1c045d http://gerrit.ovirt.org/#/c/23467/9/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/OvfDataUpdaterTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/OvfDataUpdaterTest.java: Line 94: private Map<Guid, List<Guid>> executedOvfUpdatedDomainForPool; Line 95: private Map<Guid, Map<Guid, Pair<StorageDomainOvfInfo, StoragePoolIsoMap>>> poolDomainsOvfInfo; Line 96: private Guid executedRemoveStoragePoolId; Line 97: private Guid executedRemoveStorageDomainId; Line 98: > Lots of formatting changes, unrelated to the patch. Done Line 99: @Before Line 100: public void setUp() { Line 101: updater = Mockito.spy(OvfDataUpdater.getInstance()); Line 102: doReturn(ITEMS_COUNT_PER_UPDATE).when(updater).reloadConfigValue(); Line 105: doCallRealMethod().when(updater).ovfUpdate_timer(); Line 106: // init members Line 107: initMembers(); Line 108: Line 109: // init daos > unrelated to the patch Done Line 110: doReturn(storagePoolDAO).when(updater).getStoragePoolDao(); Line 111: doReturn(vmAndTemplatesGenerationsDAO).when(updater).getVmAndTemplatesGenerationsDao(); Line 112: doReturn(vmDAO).when(updater).getVmDao(); Line 113: doReturn(vmStaticDAO).when(updater).getVmStaticDao(); -- To view, visit http://gerrit.ovirt.org/23467 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78803db10947a6ee477a493b530319654b1c045d Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
