Vojtech Szocs has posted comments on this change. Change subject: webadmin: Support for mode specific Tabs and Sub Tabs ......................................................................
Patch Set 1: Looks good to me, I just have one small note: LoginModel is the only model created before ApplicationModeHelper.setUiMode() method is called during application startup. But I think this is not important in your case, since login UI is not affected by UI mode value. -- To view, visit http://gerrit.ovirt.org/4450 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I55da9510a1480634ce30cf77b9bd9ecb263186bc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
