Alon Bar-Lev has uploaded a new change for review. Change subject: db: cleanup: remove epilogue success messages ......................................................................
db: cleanup: remove epilogue success messages these are useless, any error is clearly stated as such. Change-Id: I18c13a131af604f43686615c33f2858eb140b616 Signed-off-by: Alon Bar-Lev <[email protected]> --- M packaging/dbscripts/cleandb.sh M packaging/dbscripts/upgrade.sh M packaging/setup/dbutils/encodingvalidator.sh M packaging/setup/dbutils/validatedb.sh 4 files changed, 1 insertion(+), 20 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/20/24920/1 diff --git a/packaging/dbscripts/cleandb.sh b/packaging/dbscripts/cleandb.sh index f232e8b..670e59c 100755 --- a/packaging/dbscripts/cleandb.sh +++ b/packaging/dbscripts/cleandb.sh @@ -44,7 +44,3 @@ echo "Cleaning database..." dbfunc_database_clean - -ret=$? -echo "Done." -exit ${ret} diff --git a/packaging/dbscripts/upgrade.sh b/packaging/dbscripts/upgrade.sh index 9286a34..d226ec8 100755 --- a/packaging/dbscripts/upgrade.sh +++ b/packaging/dbscripts/upgrade.sh @@ -85,7 +85,3 @@ " > /dev/null fi dbfunc_common_upgrade - -ret=$? -echo "Done." -exit ${ret} diff --git a/packaging/setup/dbutils/encodingvalidator.sh b/packaging/setup/dbutils/encodingvalidator.sh index 6e854f4..8f1007f 100755 --- a/packaging/setup/dbutils/encodingvalidator.sh +++ b/packaging/setup/dbutils/encodingvalidator.sh @@ -100,13 +100,3 @@ fi fix_template1_encoding - -ret=$? - -if [ ${ret} -eq 0 ]; then - echo "Operation completed successfully" -else - echo "Operation failed" -fi - -exit ${ret} diff --git a/packaging/setup/dbutils/validatedb.sh b/packaging/setup/dbutils/validatedb.sh index ae98183..a24e936 100755 --- a/packaging/setup/dbutils/validatedb.sh +++ b/packaging/setup/dbutils/validatedb.sh @@ -22,8 +22,6 @@ __EOF__ } -error=0 - while [ -n "$1" ]; do x="$1" v="${x#*=}" @@ -60,6 +58,7 @@ validationlist="fkvalidator.sh" +error=0 for script in ${validationlist}; do "${dbutils}/${script}" "${USERNAME}" "${SERVERNAME}" "${PORT}" "${DATABASE}" ${LOGFILE:+-l "$LOGFILE"} -q ${extra_params} || error=1 done -- To view, visit http://gerrit.ovirt.org/24920 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I18c13a131af604f43686615c33f2858eb140b616 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
