Yair Zaslavsky has posted comments on this change. Change subject: aaa: Introducing AuthenticationProfileRepository ......................................................................
Patch Set 36: (3 comments) http://gerrit.ovirt.org/#/c/24366/36/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/Authenticator.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/Authenticator.java: Line 20: return (String) context.get(ExtensionProperties.NAME); Line 21: } Line 22: Line 23: public String getProfileName() { Line 24: return ((Properties) context.get(ExtensionProperties.CONFIGURATION)).getProperty("ovirt.engine.aaa.authn.profile.name"); wrong key was provided. fixed. Line 25: } Line 26: Line 27: Line 28: @Override http://gerrit.ovirt.org/#/c/24366/36/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java: Line 65: for (String domain : LdapBrokerUtils.getDomainsList()) { Line 66: Map<ExtensionProperties, Object> dirContext = new EnumMap<>(ExtensionProperties.class); Line 67: Properties dirProps = new Properties(); Line 68: dirProps.put("ovirt.engine.aaa.authz.profile.name", domain); Line 69: dirContext.put(ExtensionProperties.CONFIGURATION, dirProps); did not pass here dirProps, fixed. Line 70: dirContext.put(ExtensionProperties.NAME, domain); Line 71: Directory directory = new ProvisionalDirectory(); Line 72: directory.setContext(dirContext); Line 73: directory.init(); Line 74: Line 75: Map<ExtensionProperties, Object> authContext = new EnumMap<>(ExtensionProperties.class); Line 76: Properties authProps = new Properties(); Line 77: authProps.put("ovirt.engine.aaa.authn.profile.name", domain); Line 78: authContext.put(ExtensionProperties.CONFIGURATION, authProps); did not pass here authProps, fixed. Line 79: authContext.put(ExtensionProperties.NAME, domain); Line 80: Authenticator authenticator = new ProvisionalAuthenticator(); Line 81: authenticator.setContext(authContext); Line 82: authenticator.init(); -- To view, visit http://gerrit.ovirt.org/24366 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If375fccea98544c64d9ec41cc9dbcb855bf02fb7 Gerrit-PatchSet: 36 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
