Doron Fediuck has posted comments on this change.
Change subject: core: [CpuPinning] add cpu_pinning to database
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
Laszlo,
1. Please split this patch into a refactor patch and a change patch (see
inline).
2. Please follow Yair's comment as well.
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmStaticDAODbFacadeImpl.java
Line 34: getCallsHandler().executeModification("InsertVmStatic",
getFullParameterSource(vm));
Laszlo,
such cleanups are more than welcomed,
but the way you combine it with your change makes your patch difficult to
review.
Please separate into a refactor patch and a change patch.
--
To view, visit http://gerrit.ovirt.org/4543
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I808a942bed66b42b3fdb3763d122a7ea448daf95
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
