Einav Cohen has posted comments on this change. Change subject: webadmin: custom properties sheet ......................................................................
Patch Set 1: I would prefer that you didn't submit this you have checkstyle violations: frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/key_value/KeyValueModel.java:74: String ";" is non-externalized. Please externalize it by moving it to i18n Constants/Messages interface or add //$NON-NLS-1$ comment to marks the string as non externalized frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/key_value/KeyValueModel.java:83: String "=" is non-externalized. Please externalize it by moving it to i18n Constants/Messages interface or add //$NON-NLS-1$ comment to marks the string as non externalized frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/key_value/KeyValueModel.java:117: String "=" is non-externalized. Please externalize it by moving it to i18n Constants/Messages interface or add //$NON-NLS-1$ comment to marks the string as non externalized -- To view, visit http://gerrit.ovirt.org/4564 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf2020252e5af0339d0699b83117cc1b536fb93b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
