Liran Zelkha has posted comments on this change. Change subject: core: Remove error messages from log when adding host ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/24980/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsCommand.java: Line 51: protected void initializeVds() { Line 52: initializeVds(true); Line 53: } Line 54: Line 55: protected void initializeVds(boolean expectHostToBeFound) { > I would prefer only newHost because according to Java Coding Conventios isN Done Line 56: Backend.getInstance() Line 57: .getResourceManager() Line 58: .RunVdsCommand(VDSCommandType.RemoveVds, Line 59: new RemoveVdsVDSCommandParameters(getVdsId(), expectHostToBeFound)); -- To view, visit http://gerrit.ovirt.org/24980 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia17656dbfa0e16457565b04b849eb80ea74a8949 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
