Vitor de Lima has posted comments on this change. Change subject: core, engine, webadmin: Retrieve Capabilities for each Architecture ......................................................................
Patch Set 7: (4 comments) http://gerrit.ovirt.org/#/c/23238/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetArchitectureCapabilitiesQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetArchitectureCapabilitiesQuery.java: Line 23: protected void executeQueryCommand() { Line 24: setReturnValue(getMap(getParameters().getArchCapabilitiesVerb())); Line 25: } Line 26: Line 27: private Map<ArchitectureType, Map<Version, Boolean>> getMap(ArchCapabilitiesVerb archCapabilitiesVerb) { > Easiest solution is to make this method synchronized. Done Line 28: Line 29: if (verbMap.containsKey(archCapabilitiesVerb)) { Line 30: return verbMap.get(archCapabilitiesVerb); Line 31: } else { http://gerrit.ovirt.org/#/c/23238/7/packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql File packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql: Line 623: --URL or custom message to be presented upon login when the password of a user has expired. Line 624: select fn_db_add_config_value('ChangePasswordMsg','','general'); Line 625: Line 626: -- migration support per architecture Line 627: select fn_db_add_config_value('IsMigrationSupported','{"undefined": "true", "x86_64": "true", "ppc64" : "false" }','general'); > This config file is sorted by the config key , can you pleae move to the ri Done Line 628: Line 629: -- snapshot support per architecture Line 630: select fn_db_add_config_value('IsMemorySnapshotSupported','{"undefined": "true", "x86_64": "true", "ppc64" : "false" }','general'); Line 631: Line 626: -- migration support per architecture Line 627: select fn_db_add_config_value('IsMigrationSupported','{"undefined": "true", "x86_64": "true", "ppc64" : "false" }','general'); Line 628: Line 629: -- snapshot support per architecture Line 630: select fn_db_add_config_value('IsMemorySnapshotSupported','{"undefined": "true", "x86_64": "true", "ppc64" : "false" }','general'); > same Done Line 631: Line 632: -- suspend support per architecture Line 633: select fn_db_add_config_value('IsSuspendSupported','{"undefined": "true", "x86_64": "true", "ppc64" : "false" }','general'); Line 634: Line 629: -- snapshot support per architecture Line 630: select fn_db_add_config_value('IsMemorySnapshotSupported','{"undefined": "true", "x86_64": "true", "ppc64" : "false" }','general'); Line 631: Line 632: -- suspend support per architecture Line 633: select fn_db_add_config_value('IsSuspendSupported','{"undefined": "true", "x86_64": "true", "ppc64" : "false" }','general'); > same Done Line 634: Line 635: ------------------------------------------------------------------------------------ Line 636: -- Update with override section Line 637: ------------------------------------------------------------------------------------ -- To view, visit http://gerrit.ovirt.org/23238 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ied1a97f5bdd42382f0dc832a3fe3abd56d3c89dd Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Leonardo Bianconi <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vitor de Lima <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
