Hello Omer Frenkel,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/4573
to review the following change.
Change subject: core: avoid NPE whrn imageDomainsList is empty (#746469)
......................................................................
core: avoid NPE whrn imageDomainsList is empty (#746469)
https://bugzilla.redhat.com/746469
try to extract the domains list only if the structure contains the domain list.
Otherwise return an empty array, fetch the error and propogate a CanDo Message.
Change-Id: I96f589c02e8511c60f4543d8296ce1222a9ba4c5
Signed-off-by: Roy Golan <[email protected]>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java
M
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/StorageDomainGuidListReturnForXmlRpc.java
M
frontend/webadmin/modules/userportal/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
5 files changed, 28 insertions(+), 15 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/73/4573/1
--
To view, visit http://gerrit.ovirt.org/4573
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I96f589c02e8511c60f4543d8296ce1222a9ba4c5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
