Martin Sivák has posted comments on this change. Change subject: engine: Fix a possible NPE when the user removes stale policy unit ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/24953/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/SchedulingManager.java: Line 854: */ Line 855: public List<String> getClusterPoliciesNamesByPolicyUnitId(Guid policyUnitId) { Line 856: List<String> list = new ArrayList<String>(); Line 857: final PolicyUnitImpl policyUnitImpl = policyUnits.get(policyUnitId); Line 858: if (policyUnitImpl == null) { > I think that this check is not needed, can't think of any case when policyU I might not be, but better be safe thank sorry in scheduling :) Line 859: log.warnFormat("Trying to find usages of non-existing policy unit %s", policyUnitId.toString()); Line 860: return null; Line 861: } Line 862: -- To view, visit http://gerrit.ovirt.org/24953 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5fa617af3363ec1d71cf8f0a25af43be4b141067 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Kobi Ianko <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
