Yaniv Dary has posted comments on this change. Change subject: packaging: setup: added jrs pro edition deploy steps ......................................................................
Patch Set 4: (3 comments) http://gerrit.ovirt.org/#/c/25030/4/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-reports/jasper/deploy.py: Line 581 Line 582 Line 583 Line 584 Line 585 > os.path.join? This is a JRS export path. Not a physical, so it will always be with slash, not backslash. So this is the best way to do this. Line 612: what='dwhdatasourceexport', Line 613: args=( Line 614: '--uris', Line 615: reportsProRelativePath + Line 616: '/reports_resources/JDBC/data_sources/ovirt', > os.path.join? same Line 617: ), Line 618: ) Line 619: self._dwhdatasource = os.path.join( Line 620: dwhdatasourceexport, Line 619: self._dwhdatasource = os.path.join( Line 620: dwhdatasourceexport, Line 621: 'resources', Line 622: reportsProRelativePath, Line 623: '/reports_resources/JDBC/data_sources/ovirt.xml', > no need '/' at start See new patch with explanation to way this is this is going to be ugly. Line 624: ) Line 625: Line 626: self._workaroundUsersNullPaswords(self._users) Line 627: -- To view, visit http://gerrit.ovirt.org/25030 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a3f36e11d0450c031de6da6c6470024534c60e1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
