Eli Mesika has posted comments on this change. Change subject: db: cleanup: psql usage ......................................................................
Patch Set 1: (8 comments) http://gerrit.ovirt.org/#/c/25127/1//COMMIT_MSG Commit Message: Line 29: TODO Is this still relevant ? http://gerrit.ovirt.org/#/c/25127/1/packaging/dbscripts/dbfunc-base.sh File packaging/dbscripts/dbfunc-base.sh: Line 59: each each each => each Line 71: 10000000 10000000 ??? what this is for ??? please add a comment explaining that http://gerrit.ovirt.org/#/c/25127/1/packaging/dbscripts/dbfunctions.sh File packaging/dbscripts/dbfunctions.sh: Line 316 Line 317 Line 318 Line 319 Line 320 why this line is removed ??? http://gerrit.ovirt.org/#/c/25127/1/packaging/dbscripts/unlock_entity.sh File packaging/dbscripts/unlock_entity.sh: Line 17: -p PORT - The database port for the database (def. ${DBFUNC_DB_PORT}) Line 18: -d DATABASE - The database name (def. ${DBFUNC_DB_DATABASE}) Line 19: -u USER - The username for the database (def. ${DBFUNC_DB_USER}) Line 20: -l LOGFILE - The logfile for capturing output (def. ${DBFUNC_LOGFILE}) Line 21: -t TYPE - The object type {vm | template | disk | snapshot} TWS Line 22: -r - Recursive, unlocks all disks under the selected vm/template. Line 23: -q - Query db and display a list of the locked entites. Line 24: -v - Turn on verbosity (WARNING: lots of output) Line 25: -h - This help text. Line 22: -r - Recursive, unlocks all disks under the selected vm/template. Line 23: -q - Query db and display a list of the locked entites. Line 24: -v - Turn on verbosity (WARNING: lots of output) Line 25: -h - This help text. Line 26: ENTITIES - The list of object names in case of vm/template, UUIDs in case of a disk TWS (worth removing even if were in base code IMO Line 27: Line 28: __EOF__ Line 29: } Line 30: http://gerrit.ovirt.org/#/c/25127/1/packaging/dbscripts/upgrade.sh File packaging/dbscripts/upgrade.sh: Line 75: \?) usage; exit 1;; Line 76: esac Line 77: done Line 78: Line 79: dbfunc_psql_die --file="upgrade/03_02_0000_set_version.sql" > /dev/null As I see this code was moved from the upgrade func here ? why ? Line 80: if [ -n "${VERSION}" ]; then Line 81: dbfunc_psql_die --command=" Line 82: update schema_version Line 83: set current=true http://gerrit.ovirt.org/#/c/25127/1/packaging/setup/dbutils/dbfunc-base.sh File packaging/setup/dbutils/dbfunc-base.sh: Line 26: : What does this mean ??? -- To view, visit http://gerrit.ovirt.org/25127 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib93ad2ca4d35fe3f44e3f8915182778a9fe6ed66 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
