Tal Nisan has uploaded a new change for review.

Change subject: core: Fix a bug in exporting template with force override
......................................................................

core: Fix a bug in exporting template with force override

When exporting a template, the pre-existence of its images should only be
checked if the forceOveride flag is set to false

Change-Id: Ida6fbcfe00403d609f76055437a3d105ac8a8d98
Signed-off-by: Tal Nisan <[email protected]>
Bug-Url: https://bugzilla.redhat.com/1069151
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/45/25145/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java
index 9f711cb..bce37f4 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java
@@ -130,7 +130,7 @@
                 retValue =
                         checkStorageDomain()
                                 && 
checkStorageDomainStatus(StorageDomainStatus.Active)
-                                && checkIfDisksExist(getTemplateDisks())
+                                && (getParameters().getForceOverride() || 
checkIfDisksExist(getTemplateDisks()))
                                 && 
checkFreeSpaceOnDestinationDomain(getStorageDomain(),
                                         (int) 
getVmTemplate().getActualDiskSize());
             }


-- 
To view, visit http://gerrit.ovirt.org/25145
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ida6fbcfe00403d609f76055437a3d105ac8a8d98
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to