Alon Bar-Lev has posted comments on this change. Change subject: db: cleanup: rename function names ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/25129/2/packaging/dbscripts/dbfunc-common.sh File packaging/dbscripts/dbfunc-common.sh: Line 99: #drop materialized views to support views changesin upgrade Line 100: #Materialized views are restored in the post_upgrade step Line 101: dbfunc_common_hook_materialized_views_drop Line 102: Line 103: # TODO: move this to custom? > Can you elaborate please ? yes, in future patch I create hook for this and move it to dbfunc-custom, I understand this is engine specific code and not belong here. Line 104: if [ -n "${CLEAN_TASKS}" ]; then Line 105: echo "Cleaning tasks metadata..." Line 106: _dbfunc_common_delete_async_tasks_and_compensation_data Line 107: fi -- To view, visit http://gerrit.ovirt.org/25129 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icce88f1d8f19da83c757f94ad661cb676bd70274 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
