Tal Nisan has posted comments on this change.

Change subject: webadmin: Missing storage options in data center "Guide me"
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/25092/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java:

Line 3705: 
Line 3706:         LocalStorageModel localDataModel = new LocalStorageModel();
Line 3707:         localDataModel.setRole(StorageDomainType.Data);
Line 3708:         models.add(localDataModel);
Line 3709: 
> nitpicking: I'd order these so all the file based domains are grouped toget
Done, plus a couple of more nits, just for the sake of it ;)
Line 3710:         return models;
Line 3711:     }
Line 3712: 
Line 3713:     public static List<IStorageModel> getIsoStorageModels() {


-- 
To view, visit http://gerrit.ovirt.org/25092
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2c2327962efcb26c671f3479fd53a4093efbe3e1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to