Juan Hernandez has posted comments on this change. Change subject: core, restapi: Missing domain field on VM\Template object ......................................................................
Patch Set 4: (3 comments) Looks good, some minor comments. http://gerrit.ovirt.org/#/c/25154/4/backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResourceTest.java File backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResourceTest.java: Line 714: } Line 715: Line 716: @Override Line 717: protected void setUpQueryExpectations(String query, Object failure) throws Exception { Line 718: // If the query to retrieve the virtual machines succeeds, then we will run another query to add the s/virtual machines/templates/ Line 719: // initialization information: Line 720: if (failure == null) { Line 721: setUpEntityQueryExpectations( Line 722: VdcQueryType.GetVmsInit, Line 731: super.setUpQueryExpectations(query, failure); Line 732: } Line 733: Line 734: private List<VmInit> setUpVmInit() { Line 735: List<VmInit> templates = new ArrayList<>(NAMES.length); Rename "template" to "vmInits". Line 736: for (int i = 0; i < NAMES.length; i++) { Line 737: VmInit vmInit = control.createMock(VmInit.class); Line 738: VmInit init = control.createMock(VmInit.class); Line 739: templates.add(vmInit); Line 734: private List<VmInit> setUpVmInit() { Line 735: List<VmInit> templates = new ArrayList<>(NAMES.length); Line 736: for (int i = 0; i < NAMES.length; i++) { Line 737: VmInit vmInit = control.createMock(VmInit.class); Line 738: VmInit init = control.createMock(VmInit.class); Remove this ^line. Line 739: templates.add(vmInit); Line 740: } Line 741: return templates; Line 742: } -- To view, visit http://gerrit.ovirt.org/25154 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf43cb1a0d25d89ef68f21bc47b82c2cd6fdf19d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
