Vitor de Lima has posted comments on this change. Change subject: webadmin: Prevent VM suspend in the ppc64 arch ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/24015/3/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java: Line 326: Line 327: for (VM vm : items) { Line 328: result &= Line 329: AsyncDataProvider.isSuspendSupportedByArchitecture(vm.getClusterArch(), Line 330: vm.getVdsGroupCompatibilityVersion()); > Please check the result here and break if false , since all values are with Done Line 331: } Line 332: Line 333: return result; Line 334: } http://gerrit.ovirt.org/#/c/24015/3/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/VmItemBehavior.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/VmItemBehavior.java: Line 157: Line 158: getItem().getRunCommand().setIsExecutionAllowed(VdcActionUtils.canExecute(entities, Line 159: VM.class, Line 160: VdcActionType.RunVm)); Line 161: getItem().getPauseCommand().setIsExecutionAllowed(entities.size() > 0 > The entities.size() is not needed here since it is always size of 1 because Done Line 162: && VdcActionUtils.canExecute(entities, VM.class, VdcActionType.HibernateVm) Line 163: && AsyncDataProvider.canVmsBePaused(entities)); Line 164: getItem().getShutdownCommand().setIsExecutionAllowed(VdcActionUtils.canExecute(entities, Line 165: VM.class, -- To view, visit http://gerrit.ovirt.org/24015 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe6a5fd5ad1679045582afcc16aebbfba34f7429 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <[email protected]> Gerrit-Reviewer: Leonardo Bianconi <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vitor de Lima <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
