Vojtech Szocs has posted comments on this change. Change subject: packaging: build: enforce at least 10240 file descriptors for locale builds ......................................................................
Patch Set 1: Code-Review+1 (1 comment) Looks good to me! http://gerrit.ovirt.org/#/c/25115/1/Makefile File Makefile: Line 318: require="10240"; \ Line 319: current="$$(ulimit -n)"; \ Line 320: if [ "$${current}" -lt "$${require}" ]; then \ Line 321: echo "Building locales requires more than $${require} available file descriptors, currently $${require}" >&2; \ Line 322: echo "Refer to README.developer for farther instructions" >&2; \ Small typo: further instructions Line 323: false; \ Line 324: fi; \ Line 325: fi Line 326: if [ "$(BUILD_VALIDATION)" != 0 ]; then \ -- To view, visit http://gerrit.ovirt.org/25115 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e624afffc2eefb381bee25e3792bf7be60cf0b3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
