Allon Mureinik has posted comments on this change.
Change subject: core: [rmd] OvfManager
......................................................................
Patch Set 1: (7 inline comments)
basically looks good - there are some places i'd use List instead of ArrayList
(see inline), but nothing major.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java
Line 51:
why not just add a versionSerialUID?
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java
Line 245: VM tempVM = new VM();
Consider using Lists instead of ArrayLists
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetTemplatesFromExportDomainQuery.java
Line 57: if (ovfManager.IsOvfTemplate(ovf)) {
consider defining the variables as Lists
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetVmsFromExportDomainQuery.java
Line 82: vm = new VM();
consider defining the variables as Lists
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
Line 55:
why not just add a versionSerialUID?
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateCommand.java
Line 34:
why not just add a versionSerialUID?
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfManager.java
Line 19:
perhaps change the signature to accept a List instead of ArrayList while you're
at it?
--
To view, visit http://gerrit.ovirt.org/4502
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I781f152e668f51bb313b9a81822df8c21b934a1b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
