Gilad Chaplik has posted comments on this change.

Change subject: webadmin: Add new role permission drop below the end of the 
screen
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

minor comment

http://gerrit.ovirt.org/#/c/24853/1/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/RolePopupView.ui.xml
File 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/configure/RolePopupView.ui.xml:

Line 51:         .descriptionEditor {
Line 52:             position: absolute;
Line 53:             right: 2px;
Line 54:             width: 325px;
Line 55:         }
try to use tabs instead of spaces
Line 56:        </ui:style>
Line 57: 
Line 58:        <d:SimpleDialogPanel width="650px" height="500px">
Line 59:                <d:content>


-- 
To view, visit http://gerrit.ovirt.org/24853
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6f785d91c8bc10b0ceb44ed153237e5f62590b76
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to