Lior Vernia has posted comments on this change. Change subject: webadmin: adding labels column to Network->Hosts sub-tab ......................................................................
Patch Set 5: Code-Review+2 (2 comments) http://gerrit.ovirt.org/#/c/24992/5/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java: Line 1352: Line 1353: @DefaultStringValue("Network Device Tx") Line 1354: String txNetworkHost(); Line 1355: Line 1356: @DefaultStringValue("Lables") Typo... Line 1357: String labelsNetworkHost(); Line 1358: Line 1359: // Network VM Line 1360: @DefaultStringValue("vNIC Status") http://gerrit.ovirt.org/#/c/24992/5/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkHostView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkHostView.java: Line 162: TextColumnWithTooltip<PairQueryable<VdsNetworkInterface, VDS>> labelsColumn = Line 163: new TextColumnWithTooltip<PairQueryable<VdsNetworkInterface, VDS>>() { Line 164: @Override Line 165: public String getValue(PairQueryable<VdsNetworkInterface, VDS> object) { Line 166: Set<String> lablesList = object.getFirst().getLabels(); Typo... Line 167: return StringHelper.join(", ", lablesList != null ? lablesList.toArray() : null); //$NON-NLS-1$ Line 168: } Line 169: }; Line 170: -- To view, visit http://gerrit.ovirt.org/24992 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I610703df29dcae7ace390e0ebb109475fb202263 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
