Juan Hernandez has posted comments on this change. Change subject: core, engine, webadmin: Retrieve Capabilities for each Architecture ......................................................................
Patch Set 9: (3 comments) http://gerrit.ovirt.org/#/c/23238/9/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetArchitectureCapabilitiesQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetArchitectureCapabilitiesQuery.java: Line 23: protected void executeQueryCommand() { Line 24: setReturnValue(getMap(getParameters().getArchCapabilitiesVerb())); Line 25: } Line 26: Line 27: private synchronized Map<ArchitectureType, Map<Version, Boolean>> getMap(ArchCapabilitiesVerb archCapabilitiesVerb) { > why is this sync? the map doesn't change after you pick it up from FeatureS The nested maps inside verbMap change when calling the method. That isn't safe if several threads call it simultaneously. Line 28: Line 29: if (archCapabilitiesVerb == null) { Line 30: return null; Line 31: } Line 39: for (ArchitectureType arch : ArchitectureType.values()) { Line 40: Map<Version, Boolean> archMap = new HashMap<Version, Boolean>(); Line 41: Line 42: for (Version version : Version.ALL) { Line 43: archMap.put(version, isSupported(archCapabilitiesVerb, arch, version)); Here ^ . Line 44: } Line 45: Line 46: supportMap.put(arch, archMap); Line 47: } Line 42: for (Version version : Version.ALL) { Line 43: archMap.put(version, isSupported(archCapabilitiesVerb, arch, version)); Line 44: } Line 45: Line 46: supportMap.put(arch, archMap); And here ^. Line 47: } Line 48: Line 49: verbMap.put(archCapabilitiesVerb, supportMap); Line 50: -- To view, visit http://gerrit.ovirt.org/23238 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ied1a97f5bdd42382f0dc832a3fe3abd56d3c89dd Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Leonardo Bianconi <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vitor de Lima <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
