Yaniv Dary has posted comments on this change. Change subject: reports:Fixed bug in br18-chart vms with known OS vs. unknown ......................................................................
Patch Set 7: (6 comments) http://gerrit.ovirt.org/#/c/24981/7/packaging/ovirt-reports/resources/Reports/Executive/active_vms_by_os_br18_files/active_vms_by_os_br18_jrxml.data File packaging/ovirt-reports/resources/Reports/Executive/active_vms_by_os_br18_files/active_vms_by_os_br18_jrxml.data: Line 84: v3_4_configuration_history_vms.operating_system Line 85: AND enum_os_type.enum_type = 'OS_TYPE' Line 86: AND language_code = 'en_US' Line 87: ) Line 88: INNER JOIN v3_4_configuration_history_vms latest_config Indention here is incorrect the join is with the stats table Line 89: ON ( Line 90: latest_config.vm_id = Line 91: v3_4_statistics_vms_resources_usage_$P!{table_name}.vm_id Line 92: ) Line 91: v3_4_statistics_vms_resources_usage_$P!{table_name}.vm_id Line 92: ) Line 93: WHERE Line 94: -- Here we filter only the vms that are in active status Line 95: v3_4_statistics_vms_resources_usage_$P!{table_name}.vm_status = 1 too many spaces here Line 96: -- Filter vms list according to the datacenter that was chosen by the user Line 97: AND v3_4_configuration_history_vms.cluster_id in Line 98: ( Line 99: SELECT cluster_id Line 257: v3_4_configuration_history_vms.operating_system Line 258: AND enum_os_type.enum_type = 'OS_TYPE' Line 259: AND language_code = 'en_US' Line 260: ) Line 261: INNER JOIN v3_4_configuration_history_vms latest_config same issue with join indent Line 262: ON ( Line 263: latest_config.vm_id = Line 264: v3_4_statistics_vms_resources_usage_$P!{table_name}.vm_id Line 265: ) Line 262: ON ( Line 263: latest_config.vm_id = Line 264: v3_4_statistics_vms_resources_usage_$P!{table_name}.vm_id Line 265: ) Line 266: WHERE tailing whitespace Line 267: -- Filter vms list according to the datacenter that was chosen by the user Line 268: v3_4_configuration_history_vms.cluster_id IN ( Line 269: SELECT cluster_id Line 270: FROM v3_4_configuration_history_clusters Line 397: ON ( Line 398: v3_4_configuration_history_vms.history_id = Line 399: v3_4_statistics_vms_resources_usage_$P!{table_name}.vm_configuration_version Line 400: ) Line 401: INNER JOIN enum_translator enum_os_type indent is incorrect, joins with the config table above it, so need to be pushed one ahead. Line 402: ON ( Line 403: enum_os_type.enum_key = Line 404: v3_4_configuration_history_vms.operating_system Line 405: AND enum_os_type.enum_type = 'OS_TYPE' Line 410: latest_config.vm_id = Line 411: v3_4_statistics_vms_resources_usage_$P!{table_name}.vm_id Line 412: ) Line 413: WHERE v3_4_statistics_vms_resources_usage_$P!{table_name}.vm_status = 1 Line 414: AND UPPER ( enum_os_type.value ) like 'WINDOWS%' I would add another % '%WINDOWS%' Line 415: -- Filter vms list according to the datacenter that was chosen by the user Line 416: AND v3_4_configuration_history_vms.cluster_id IN Line 417: ( Line 418: SELECT cluster_id -- To view, visit http://gerrit.ovirt.org/24981 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icdecb4e0bc4ac4ce5d6ab2000aa0812aa3ea5c2c Gerrit-PatchSet: 7 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <[email protected]> Gerrit-Reviewer: Shirly Radco <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
