Martin Peřina has posted comments on this change.

Change subject: tools: fix event_subscribers upgrade script.
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/25372/1/packaging/dbscripts/upgrade/03_05_0050_event_notification_methods.sql
File packaging/dbscripts/upgrade/03_05_0050_event_notification_methods.sql:

Line 11:   ADD CONSTRAINT pk_event_subscriber PRIMARY KEY (subscriber_id, 
event_up_name, notification_method, tag_name);
Line 12: ALTER TABLE event_subscriber DROP COLUMN method_id;
Line 13: 
Line 14: 
Line 15: ALTER TABLE event_subscriber ALTER notification_method SET NOT NULL;
Wouldn't it be better to move also this command to line 9 after UPDATE command?
Line 16: 
Line 17: 
------------------------------------------------------------------------------------------
Line 18: -- Remove the connection between a subscription address and the 
subscribing system user --
Line 19: 
------------------------------------------------------------------------------------------


-- 
To view, visit http://gerrit.ovirt.org/25372
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I42813681562e1030a3c9a16bd091920189ce49ef
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: mooli tayer <[email protected]>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to