Shireesh Anjal has uploaded a new change for review. Change subject: engine: create gluster volume - fixed NPE ......................................................................
engine: create gluster volume - fixed NPE https://bugzilla.redhat.com/823285 Create volume sometimes fails with NPE. This was happening when the VDS command throws exception, and hence the variable errorType remains unassigned. Modified getAuditLogTypeValue to return GLUSTER_VOLUME_CREATE_FAILED in such cases. Als performed following changes: - Introduced method(s) handleVdsError(s) in GlusterCommandBase for standard logic to handle failure in the VDS command - Modified executeCommand to handle VDS error if any coming from CreateGlusterVolumeVDSCommand Change-Id: Ia438153a11fe952e616b1b5ddfaa0a6c1d4f6ec8 Signed-off-by: Shireesh Anjal <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/CreateGlusterVolumeCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterCommandBase.java 2 files changed, 21 insertions(+), 7 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/51/4651/1 -- To view, visit http://gerrit.ovirt.org/4651 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia438153a11fe952e616b1b5ddfaa0a6c1d4f6ec8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
