Vojtech Szocs has posted comments on this change.
Change subject: webadmin,userportal: Persistent client-side logging
infrastructure
......................................................................
Patch Set 1: Verified+1
(1 comment)
Verified by placing following code in ApplicationInit.performBootstrap:
// processed by LocalStorageLogHandler
Logger.getLogger(ApplicationInit.class.getName()).info("TEST info log");
// caught by UncaughtExceptionHandler, logged, processed by
LocalStorageLogHandler
throw new RuntimeException("TEST uncaught exception");
http://gerrit.ovirt.org/#/c/25444/1/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/AddOnlyRingBuffer.java
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/AddOnlyRingBuffer.java:
Line 64: // Buffer is full, need to move the head
Line 65: else {
Line 66: int index = head;
Line 67: head = (head + 1) % capacity;
Line 68: old = delegate.read(index);
Note to reviewers: this might seem as redundant behavior, as it yields Local
Storage read operation.
The reason for having return value in add method is better testability of add
logic. Given the consequences, I guess I can remove return value in add method.
I'd like to hear your opinion here!
Line 69: delegate.write(index, element);
Line 70: }
Line 71:
Line 72: return old;
--
To view, visit http://gerrit.ovirt.org/25444
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3b0be449ab425b56a1d7c39efeb1793991e58fa7
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Greg Sheremeta <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
