Sandro Bonazzola has posted comments on this change. Change subject: bin: add the host to a specific cluster ......................................................................
Patch Set 4: (2 comments) http://gerrit.ovirt.org/#/c/25456/4/src/plugins/ovirt-hosted-engine-setup/engine/add_host.py File src/plugins/ovirt-hosted-engine-setup/engine/add_host.py: Line 415: ca_file=self.cert, Line 416: ) Line 417: self.logger.debug('Adding the host to the cluster') Line 418: cluster_l=[c.get_name() for c in engine_api.clusters.list()] Line 419: cluster_name='Default' if cluster_name not in cluster_l \ ./add_host.py:402:21: E225 missing whitespace around operator ./add_host.py:418:22: E225 missing whitespace around operator ./add_host.py:419:25: E225 missing whitespace around operator Line 420: else cluster_l[0] Line 421: cluster_name = self.dialog.queryString( Line 422: name='cluster_name', Line 423: note=_( Line 421: cluster_name = self.dialog.queryString( Line 422: name='cluster_name', Line 423: note=_( Line 424: 'Enter the cluster that you want to add the host ' Line 425: 'to [@DEFAULT@]: ' maybe also (@VALUES@) and validValues=','.join(cluster_l), Line 426: ), Line 427: prompt=True, Line 428: default=cluster_name, Line 429: ) -- To view, visit http://gerrit.ovirt.org/25456 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00167e70296645e5cf732b64d87efa1cf66ca783 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Meital Bourvine <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
