Hello Omer Frenkel,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/4656
to review the following change.
Change subject: core: Avoid aborting the current TX when restoring stateless VM
......................................................................
core: Avoid aborting the current TX when restoring stateless VM
problem:
when destroing a Vm there is some action taken in new transaction
which invokes internal commands that can abort it.
solution:
invoke the code with the posiblle side-effects in a new transaction. the
outcome of this flow
is not relevant, we just need to isolate it in a new TX to prevent rollbacking
the current.
backgroud:
When a stateless VM is destroyed we invoke the a method that treats a VM stop
in the event listener. This direct invocation of the event listerner is
exclusive to the Destroy command
for usually, the treatment is invoked when the VM status, which is reported by
VDSM, is changing.
Since the VM has been destoryed already its not reported anymore and the
proccessOnVmStop must be called manually.
Change-Id: I623e118420a748d091699049242a050248ca1ce1
Signed-off-by: Roy Golan <[email protected]>
---
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/DestroyVmVDSCommand.java
1 file changed, 22 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/56/4656/1
--
To view, visit http://gerrit.ovirt.org/4656
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I623e118420a748d091699049242a050248ca1ce1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
