Yair Zaslavsky has posted comments on this change.
Change subject: engine: fixed integer comparison bug
......................................................................
Patch Set 1: Looks good to me, approved
(1 inline comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeEntity.java
Line 402: private boolean equalIntegers(Integer int1, Integer int2) {
Actually , ignore my comment.
common is used by gwt as well.
Not sure how will it work with compiling GWT.
I will give you +2 on that, and I will consult about this issue.
--
To view, visit http://gerrit.ovirt.org/4658
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id5dbf11d45890062ada7718dd6a069bd2ab51465
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
