Lior Vernia has posted comments on this change. Change subject: webadmin: Labeled Networks with vlan shown outside the label group ......................................................................
Patch Set 2: Code-Review+2 (1 comment) Note the comment... http://gerrit.ovirt.org/#/c/25477/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java: Line 756: } Line 757: } Line 758: Line 759: // attach label itself to nic Line 760: if (!labelModel.getNetworks().isEmpty()) { This works, but I'm not sure that this is the right place to do it. Consider adding the label to the interface without this check, and to alter the drawing logic in NewtorkGroup according to whether the label has any networks. Line 761: nicLabels.add(labelModel); Line 762: } Line 763: } Line 764: } -- To view, visit http://gerrit.ovirt.org/25477 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iefbe55854ac5b4cad6c8ab79b93edf5500fb0a81 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
