Moti Asayag has posted comments on this change. Change subject: engine: Remove port if hot plug new ext. nic fails ......................................................................
Patch Set 1: Code-Review+2 (2 comments) http://gerrit.ovirt.org/#/c/25478/1//COMMIT_MSG Commit Message: Line 15: Line 16: In this fix, a new vNIC that fails to hot plug will also be removed from Line 17: the external provider. Line 18: At this point, there is no need to remove should the hot plug of an Line 19: existing vNIC fails, as the entity that was create on the external s/create/created Line 20: provider should be removed only when the vNIC is being removed, or the Line 21: network is not used by it anymore. Line 22: Line 23: Change-Id: Iddeac63a47286e9b83ac02fb2e55f7dd56092805 http://gerrit.ovirt.org/#/c/25478/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java: Line 163: private NetworkProviderProxy getProviderProxy() { Line 164: if (providerProxy == null) { Line 165: Provider<?> provider = getDbFacade().getProviderDao().get(getNetwork().getProvidedBy().getProviderId()); Line 166: providerProxy = ProviderProxyFactory.getInstance().create(provider); Line 167: } please add a space line Line 168: return providerProxy; Line 169: } Line 170: Line 171: private TransactionMethod<Void> updateDevice() { -- To view, visit http://gerrit.ovirt.org/25478 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iddeac63a47286e9b83ac02fb2e55f7dd56092805 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
