Allon Mureinik has posted comments on this change. Change subject: core: version fix ......................................................................
Patch Set 1: Perhaps we should add a log INFO message that the version string has more parts that are silently ignored? In this implementation, 3.1.0.0.1 and 3.1.0.0.7 will be handled in the exact same way- which may be OK, but I'm not sure it's intuitive. -- To view, visit http://gerrit.ovirt.org/4679 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42dbe36b83c78d4ff2940b2d8b3e5ff5b0f59b19 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
