Michael Pasternak has posted comments on this change. Change subject: restapi: Gluster Volume resource implementation ......................................................................
Patch Set 1: Looks good to me, approved (1 inline comment) besides of using isSetX(): isSetForce() instead of action.isForce() == null in terms of code consistency i have nothing to add - all good. .................................................... File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterVolumeResource.java Line 53: action.isForce() == null ? false : action.isForce()), action); you have isSetX() on all jaxb generated properties (which is equal to action.isForce() != null ) -- To view, visit http://gerrit.ovirt.org/4677 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8206f91ebc003332bc3d1ae8535a23dab568a30 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shireesh Anjal <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
