Michael Pasternak has posted comments on this change. Change subject: sdk: Add overloaded methods for headers ......................................................................
Patch Set 1: Code-Review-1 (8 comments) http://gerrit.ovirt.org/#/c/25559/1/ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Clusters.java File ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/Clusters.java: Line 226: * @param expect Line 227: * <pre> Line 228: * [201-created] Line 229: * </pre> Line 230: * @param correlationId there is no 'correlationId' in this signature AFAICS Line 231: * <pre> Line 232: * [any string] Line 233: * </pre> Line 234: * @return http://gerrit.ovirt.org/#/c/25559/1/ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenter.java File ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenter.java: Line 206 Line 207 Line 208 Line 209 Line 210 where this one ^ gone? Line 244: * <pre> Line 245: * [action.force] Line 246: * [action.async] Line 247: * [action.grace_period.expiry] Line 248: * </pre> there is no body (action) in this signature Line 249: * Line 250: * @return Line 251: * {@link Response } Line 252: * Line 276: * <pre> Line 277: * [action.force] Line 278: * [action.async] Line 279: * [action.grace_period.expiry] Line 280: * </pre> there is no body (action) in this signature Line 281: * Line 282: * @param async Line 283: * <pre> Line 284: * [true|false] Line 317: * [action.force] Line 318: * [action.async] Line 319: * [action.grace_period.expiry] Line 320: * </pre> Line 321: * there is no body (action) in this signature Line 322: * @param correlationId Line 323: * <pre> Line 324: * [any string] Line 325: * </pre> http://gerrit.ovirt.org/#/c/25559/1/ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterClusterNetwork.java File ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterClusterNetwork.java: Line 111 Line 112 Line 113 Line 114 Line 115 where this one ^ gone? http://gerrit.ovirt.org/#/c/25559/1/ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterClusterNetworks.java File ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/DataCenterClusterNetworks.java: Line 177: * @param expect Line 178: * <pre> Line 179: * [201-created] Line 180: * </pre> Line 181: * @param correlationId there is no 'correlationId' in this signature Line 182: * <pre> Line 183: * [any string] Line 184: * </pre> Line 185: * @return http://gerrit.ovirt.org/#/c/25559/1/ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMs.java File ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/decorators/VMs.java: Line 484: * @param correlationId Line 485: * <pre> Line 486: * [any string] Line 487: * </pre> Line 488: * @param expect there is no 'expect' in this signature Line 489: * <pre> Line 490: * [201-created] Line 491: * </pre> Line 492: * @return -- To view, visit http://gerrit.ovirt.org/25559 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78bba153bfa619c9d1d930afc6c236a03c071ced Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
