Alona Kaplan has posted comments on this change. Change subject: engine: event should contain the iface which exceeded defined threshold ......................................................................
Patch Set 2: (3 comments) http://gerrit.ovirt.org/#/c/25609/2/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java: Line 107: HOST_REFRESH_CAPABILITIES_FAILED(607, AuditLogSeverity.ERROR), Line 108: Line 109: RECEIVE_RATE(608), Line 110: TRANSMIT_RATE(609), Line 111: VDS_INTERFACE_HIGH_NETWORK_USE(610, AuditLogSeverity.WARNING, > s/VDS_INTERFACE_HIGH_NETWORK_USE/HOST_INTERFACE_HIGH_NETWORK_USE There is an update script. Forgot to add it to the patch... Line 112: AuditLogTimeInterval.MINUTE.getValue() * 30), Line 113: Line 114: // Disk alignment audit logs Line 115: DISK_ALIGNMENT_SCAN_START(700), http://gerrit.ovirt.org/#/c/25609/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java: Line 304: iface.getStatistics().getReceiveRate(), Line 305: AuditLogType.RECEIVE_RATE); Line 306: checkNetwrokInterfaceThreshold(iface, Line 307: iface.getStatistics().getTransmitRate(), Line 308: AuditLogType.TRANSMIT_RATE); > this might end up with 2 events per host's nic which is too granular. I'd r Done Line 309: } Line 310: } Line 311: Line 312: private void checkNetwrokInterfaceThreshold(VdsNetworkInterface iface, Double rate, Line 315: if (rate != null && rate.intValue() > maxUsedPercentageThreshold) { Line 316: AuditLogableBase logable = new AuditLogableBase(_vds.getId()); Line 317: logable.setCustomId(iface.getName().toString() + rateType.toString()); Line 318: logable.addCustomValue("InterfaceName", iface.getName()); Line 319: logable.addCustomValue("HostName", _vds.getName()); > you can use setVdsName is protected... Line 320: logable.addCustomValue("RateType", AuditLogDirector.getMessage(rateType)); Line 321: logable.addCustomValue("UsedNetwork", String.valueOf(rate.intValue())); Line 322: logable.addCustomValue("Threshold", maxUsedPercentageThreshold.toString()); Line 323: auditLog(logable, AuditLogType.VDS_INTERFACE_HIGH_NETWORK_USE); -- To view, visit http://gerrit.ovirt.org/25609 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I22b3510398ac6fa3acf93fcb596dd6ea10b26366 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
