Tomas Jelinek has posted comments on this change. Change subject: webadmin: new instance type dialog + instance type list ......................................................................
Patch Set 26: (1 comment) http://gerrit.ovirt.org/#/c/21821/26/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/instancetypes/InstanceTypeListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/instancetypes/InstanceTypeListModel.java: Line 264: UnitVmModel model = new UnitVmModel(behavior); Line 265: setWindow(model); Line 266: Line 267: model.setTitle(title); Line 268: model.setHashName(hashName); //$NON-NLS-1$ > setHelpTag()? yes, but the git version on which this patch is based on is a little bit older than the one where the HelpTag has been introduced - will remember to add it here during rebase. Line 269: model.setIsNew(isNew); Line 270: Line 271: model.initialize(null); Line 272: -- To view, visit http://gerrit.ovirt.org/21821 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09722a0c3879268a6c683d88630440b6f8d8f794 Gerrit-PatchSet: 26 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
