Liron Ar has posted comments on this change. Change subject: core: change domains status to unknown when there are no reporting hosts ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/25542/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java: Line 199: .getAllForStoragePoolAndStatus(_storagePoolId, reportingVdsStatus) Line 200: .isEmpty()) { Line 201: StoragePoolDomainHelper.updateApplicablePoolDomainsStatuses(_storagePoolId, Line 202: StoragePoolDomainHelper.storageDomainMonitoredStatus, Line 203: StorageDomainStatus.Unknown); > but if the domain is already in status inactive, then we do know that once, As you wrote - hosts reported it to be inactive - if we don't have the reports from those hosts, they report isn't relevant as there are no used reports from them. the domain status is the current status - the "inactive" status means one thing- the domain was reported as problematic by all the hosts. If there are no hosts, we can't conclude anything on the domain, the same way as your approach we could say that we will leave the domain "active" because hosts reported it as active, "active" and "unknown" are both derived from reports. The scenario you provided isn't relevant IMO, but let's go on with it, i can give you a negative scenario - consider the following, the user has an dc with one host and one inactive domain. the host is on maintenance, the user doesn't attempt to use it because the domain appears as problematic although the host can access it because he thinks that it's "inactive" the meaning of the inactive status is that all the hosts have problematic connection to the domain, if there are no hosts , the domain shouldn't be marked as "problematic" or "active". Line 204: } Line 205: Line 206: if (storagePool.getStatus() == StoragePoolStatus.Up Line 207: || storagePool.getStatus() == StoragePoolStatus.NonResponsive || storagePool -- To view, visit http://gerrit.ovirt.org/25542 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8091a4864711aeccee41effb1bc7d9823a1870c7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
