Lior Vernia has posted comments on this change. Change subject: webadmin: Overload ListModel.setItems() with selectedItem ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/25651/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ListModel.java: Line 254: } else { Line 255: List<T> selectedItems = new ArrayList<T>(); Line 256: selectedItems.add(selectedItem); Line 257: setSelectedItem(selectedItem); Line 258: setSelectedItems(selectedItems); > selectedItem/s event will be invoked before items event? does the item alre They will be invoked before the itemsChangedEvent is fired, yes. Note that this is similar to the existing behavior before this patch (only previously this selected item was always null). Not sure I understand the second question. The item to be selected should be passed by the developer along with the items being set. Of course it doesn't have to be part the collection of items itself (consistently with what has been allowed so far). Line 259: } Line 260: } Line 261: Line 262: protected void itemsChanged() -- To view, visit http://gerrit.ovirt.org/25651 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id6de644297cdd5eb965720fc64aea1a5a735ea24 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
