Gilad Chaplik has posted comments on this change. Change subject: userportal,webadmin: NotEmptyValidation removal (#823282) ......................................................................
Patch Set 2: the bug fixed in http://gerrit.ovirt.org/#change,4571 is not related to this fix. a scenario that fails this patch: this patch assumes that names should always contain value: if a empty name is valid (in the reg-ex - but there is another error), the error message will be: "should contain at least one char...", which is wrong. another thing is that I think there should be a different error message for empty values and reg-ex validation. -- To view, visit http://gerrit.ovirt.org/4690 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21561bd394fa566604c1ea870097e8c5adb40b77 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
