Maor Lipchuk has uploaded a new change for review. Change subject: core: Removing the use of getDisks from RestoreCommand ......................................................................
core: Removing the use of getDisks from RestoreCommand There is no place that initializes the disks in the parameter class when RestoreAllSnapshot is called. Since there is no use of it whatsoever, this patch removes the use of it in the command, so we can decouple RestoreAllSnapshotsParameters from TryBackToAllSnapshotsOfVmParameters Change-Id: I1d0f5f92288ea92c114526e0d7d567a7ece45fbd Related to Bug-Url: https://bugzilla.redhat.com/867339 Signed-off-by: Maor Lipchuk <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/89/25689/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java index 85e4d25..5aaaf84 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java @@ -297,7 +297,7 @@ snapshotsManager.attempToRestoreVmConfigurationFromSnapshot(getVm(), targetSnapshot, targetSnapshot.getId(), - getParameters().getDisks(), + null, getCompensationContext(), getVm().getVdsGroupCompatibilityVersion(), getCurrentUser()); getSnapshotDao().remove(targetSnapshot.getId()); // add active snapshot with status locked, so that other commands that depend on the VM's snapshots won't run in parallel @@ -305,7 +305,6 @@ getVm(), SnapshotStatus.LOCKED, targetSnapshot.getMemoryVolume(), - getParameters().getDisks(), getCompensationContext()); } -- To view, visit http://gerrit.ovirt.org/25689 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1d0f5f92288ea92c114526e0d7d567a7ece45fbd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Maor Lipchuk <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
