Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: Take package names from environment ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/25714/2/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/distro-rpm/packages.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/distro-rpm/packages.py: Line 59: { Line 60: 'group': osetupcons.Const.UPGRADE_YUM_GROUP, Line 61: 'packages': tolist( Line 62: self.environment[osetupcons.RPMDistroEnv.ENGINE_PACKAGES] Line 63: ), Why is this needed? Isn't self.environment[osetupcons.RPMDistroEnv.ENGINE_PACKAGES] == osetupcons.Const.ENGINE_PACKAGE_NAME ? Line 64: }, Line 65: ) Line 66: self.environment[ Line 67: osetupcons.RPMDistroEnv.PACKAGES_SETUP -- To view, visit http://gerrit.ovirt.org/25714 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibad05b1e0283b0b27fb278a0ba15b3f7e95d747c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
