Yair Zaslavsky has uploaded a new change for review.

Change subject: aaa: Fix findbugs warning
......................................................................

aaa: Fix findbugs warning

Change-Id: I85ff93ea3ac54cd139ce36691fbfb38514e0edb9
Topic: AAA
Signed-off-by: Yair Zaslavsky <[email protected]>
---
M 
backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticationFilter.java
1 file changed, 0 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/24/25724/1

diff --git 
a/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticationFilter.java
 
b/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticationFilter.java
index f7640c7..356ffc8 100644
--- 
a/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticationFilter.java
+++ 
b/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/AuthenticationFilter.java
@@ -125,12 +125,6 @@
 
             NegotiationResult result = 
profile.getAuthenticator().negotiate(req, rsp);
 
-            // If the negotiation isn't finished then we assume that the 
response has been populated by the
-            // authenticator and we just let the container sent it back to the 
client:
-            if (result == null) {
-                return;
-            }
-
             // If the negotiation is finished and authentication succeeded 
then we have to remember in the session that
             // the user has been authenticated and its login name, also we 
need to clean the stack of authenticators and
             // replace the request with a wrapper that contains the user name 
returned by the authenticator:


-- 
To view, visit http://gerrit.ovirt.org/25724
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I85ff93ea3ac54cd139ce36691fbfb38514e0edb9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to