Lior Vernia has uploaded a new change for review. Change subject: engine: Set VLAN tag for external networks ......................................................................
engine: Set VLAN tag for external networks Previously the VLAN tag for external networks was being set to null on purpose, but this was inconsistent with the behavior of importing external networks. Change-Id: Ia332e08800b866702961e3c8c274c9438ebad62a Bug-Url: https://bugzilla.redhat.com/1031382 Signed-off-by: Lior Vernia <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/AddNetworkOnProviderCommand.java 1 file changed, 0 insertions(+), 9 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/43/25743/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/AddNetworkOnProviderCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/AddNetworkOnProviderCommand.java index 140f022..2887f2a 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/AddNetworkOnProviderCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/provider/network/AddNetworkOnProviderCommand.java @@ -40,7 +40,6 @@ protected void executeCommand() { NetworkProviderProxy proxy = ProviderProxyFactory.getInstance().create(getProvider()); getNetwork().getProvidedBy().setExternalId(proxy.add(getNetwork())); - getNetwork().setVlanId(null); TransactionSupport.executeInNewTransaction(new TransactionMethod<Void>() { @@ -73,14 +72,6 @@ public ValidationResult mtuValid() { return network.getMtu() == 0 ? ValidationResult.VALID : new ValidationResult(VdcBllMessages.ACTION_TYPE_FAILED_EXTERNAL_NETWORK_CANNOT_HAVE_MTU); - } - - /** - * VLAN ID is not relevant in this case, so don't check it. - */ - @Override - public ValidationResult vlanIdNotUsed() { - return ValidationResult.VALID; } } } -- To view, visit http://gerrit.ovirt.org/25743 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia332e08800b866702961e3c8c274c9438ebad62a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
