Moti Asayag has posted comments on this change. Change subject: Fix warning for StorageHelperDirector ......................................................................
Patch Set 1: (2 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperDirector.java Line 22: java.lang.Class actionType = null; same change could be done here as well - since it is the same type of warning. Line 33: java.lang.reflect.Constructor<?> info = actionType.getConstructors()[0]; I'm fine with not doing it, however i do recommend on compiling the sources after rebase before merging the patch. compilation takes ~4 minutes (with webadmin) -- To view, visit http://gerrit.ovirt.org/4681 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab0652d83b6fffa28fd4bc37a84ab616647cf813 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
