Shirly Radco has posted comments on this change. Change subject: reports: br9 report - added comments to queries ......................................................................
Patch Set 3: (3 comments) http://gerrit.ovirt.org/#/c/25147/3/packaging/ovirt-reports/resources/Reports/Inventory/VM_Inventory_files/VM_Inventory_jrxml.data File packaging/ovirt-reports/resources/Reports/Inventory/VM_Inventory_files/VM_Inventory_jrxml.data: Line 56: <parameter name="P_Locale" class="java.lang.String"> Line 57: <defaultValueExpression><![CDATA[$P{REPORT_LOCALE}.toString()]]></defaultValueExpression> Line 58: </parameter> Line 59: <queryString language="SQL"> Line 60: <![CDATA[-- BR9 - This query will return for the specific datacenter , the VMs > it's VMs* Done Line 61: -- a configurations list, grouped by clusters. Line 62: Line 63: SELECT Line 64: v3_4_configuration_history_vms.cluster_id, Line 57: <defaultValueExpression><![CDATA[$P{REPORT_LOCALE}.toString()]]></defaultValueExpression> Line 58: </parameter> Line 59: <queryString language="SQL"> Line 60: <![CDATA[-- BR9 - This query will return for the specific datacenter , the VMs Line 61: -- a configurations list, grouped by clusters. > The VMs latest configuration* Done Line 62: Line 63: SELECT Line 64: v3_4_configuration_history_vms.cluster_id, Line 65: v3_4_configuration_history_clusters.cluster_name, Line 133: enum_translator_default.enum_key Line 134: ) Line 135: WHERE language_code = 'en_US' Line 136: ) Line 137: AS b > the above joins are not ordered correctly. Done Line 138: ON ( Line 139: v3_4_configuration_history_vms.operating_system = Line 140: b.enum_key AND b.enum_type = 'OS_TYPE' Line 141: ) -- To view, visit http://gerrit.ovirt.org/25147 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7215dbbd2c5e457229055daad4283fe0606b9abe Gerrit-PatchSet: 3 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Shirly Radco <[email protected]> Gerrit-Reviewer: Shirly Radco <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
