Francesco Romani has posted comments on this change. Change subject: Implementation for CPU topology reporting ......................................................................
Patch Set 9: Code-Review+1 (1 comment) looks OK http://gerrit.ovirt.org/#/c/23268/9/ovirt-guest-agent/OVirtAgentLogic.py File ovirt-guest-agent/OVirtAgentLogic.py: Line 190: cpusecs -= 1 Line 191: if cpusecs <= 0: Line 192: if self.apiVersion >= 1: Line 193: self.sendCPUTopology() Line 194: cpusecs = self.cpuTopologyCheckRate All of the above (something -= 1...) can probably refactored using a common infrastructure. Of course this is 100% unrelated, just catched my eye. Line 195: time.sleep(1) Line 196: logging.debug("AgentLogicBase:: doWork() exiting") Line 197: except: Line 198: logging.exception("AgentLogicBase::doWork") -- To view, visit http://gerrit.ovirt.org/23268 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If937fd33d2efa11425c814188df2087a85af8357 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
